567106 - crash during initial fetch from imap account [@ msg_parse_Header_addresses]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Edoardo Panfili]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; it; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Gecko/20100519 Thunderbird/3.1

thunderbird crash during email fetch (some thousand)

after a restart it chashes again than starts work the next time.


Reproducible: Sometimes

Steps to Reproduce:
1.download Gecko/20100519 Thunderbird/3.1
2.rm rm -r ~/Library/Thunderbird 
3.start thunderbird
4.create new imap account (no password)
5.accept security exception (for smtp server)
6.click on "download mail" put password, don't check "use password manager"
7.click on a imap subfolder

I did many try but about 5/7 fails.

Actual Results:  
thunderbird crash 4/7 and 1/7hangs

Comment 1

[Ludovic Hirlimann [:Usul]]

Can you give us a crash id (see http://support.mozillamessaging.com/en-US/kb/Mozilla+Crash+Reporter) ?

Comment 2

[Wayne Mery (:wsmwk)]

the crash is within this time period https://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&platform=mac&branch=1.9.2&range_value=2&range_unit=hours&date=05%2F20%2F2010+07%3A39%3A28&query_search=signature&query_type=exact&query=&build_id=&process_type=any&hang_type=any&do_query=1 and based on crash comments, one of the crashes is bp-7160aaac-1dac-438f-bddc-252402100520 msg_parse_Header_addresses, which is bug 554581.  Are there other crashes

Comment 3

[David :Bienvenu]

I had hoped that the fix for bug 564698 might have fixed this as well, but it looks like you're running a build with that fix.

Comment 4

[Edoardo Panfili]

the last crash report is: bp-bc5e4070-ee17-4550-9367-091112100520

(i am sorry but during test I removed the thunderbird setting folder)

Comment 5

[Mark Banner (:standard8)]

Edoardo, is this just one message you are getting the issue on?

Is there a way you could try and view that, either on disk or webmail and find out what the to: and from: headers consist of?

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #3)
> I had hoped that the fix for bug 564698 might have fixed this as well, but it
> looks like you're running a build with that fix.

We did do a subsequent change in that code in bug 549931, but I'm not yet sure what is going on here to cause that, unless we're going too far.

Comment 7

[Edoardo Panfili]

I am sorry for my english... i think that i didn't understand....

(In reply to comment #5)
> Edoardo, is this just one message you are getting the issue on?
the issue is not regarding a particolar message as far as can I see: can I make
specific test (the inbox uses about 10 folders and thousand of messages)


> Is there a way you could try and view that, either on disk or webmail and find
> out what the to: and from: headers consist of?
I can't confirm that the problem regards a particular message. I use lanikai in
my work account and this isssue in not present. (it never hangs)


can I do some particular tests?

Comment 8

[Edoardo Panfili]

did other tests:

launch fresh instalation and fill all the informations: 2 tests OK

launch fresh instalation and fill all but password, then ask to download mail (don't remember password): 2 test fails
bp-a9e6f30d-e895-485c-8594-ae8332100520
bp-0beb878f-ac25-49d3-aab3-e70352100520

launch fresh instalation and fill all but password, then ask to download mail (remember password): 2 test fails
bp-0a9f532d-09f0-4941-ad30-2b3cf2100520 
no report for second crash (is it usefull to send all the reports?)

launch fresh instalation and fill password(don't remember password): 2 test OK

I compare two successive crashes, it does not occurs on the same message.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to comment #8)
> did other tests:
> 
> launch fresh instalation and fill all the informations: 2 tests OK
> 
> launch fresh instalation and fill all but password, then ask to download mail
> (don't remember password): 2 test fails
> bp-a9e6f30d-e895-485c-8594-ae8332100520 msg_parse_Header_addresses
> bp-0beb878f-ac25-49d3-aab3-e70352100520  ""
> 
> launch fresh instalation and fill all but password, then ask to download mail
> (remember password): 2 test fails
> bp-0a9f532d-09f0-4941-ad30-2b3cf2100520  nsSSLThread::requestRead(nsNSSSocketInfo*, void*, int, unsigned int) - no bug report

Comment 10

[Mark Banner (:standard8)]

Attachment: Proposed fix

Tidy up our handling of group separators.

Comment 11

[David :Bienvenu]

Comment on attachment 446707 [details] [diff] [review]
Proposed fix

probably should add a test for the ':' handling in a mailbox as well.

Comment 12

[Mark Banner (:standard8)]

Checked into trunk: http://hg.mozilla.org/comm-central/rev/d6a6df09a1b3

Comment 13

[Mark Banner (:standard8)]

Edoardo: I've done a test build here that includes the patch:

http://s3.mozillamessaging.com/build/try-server/2010-05-21_08:[e-mail]-st8-567106-parse/[e-mail]

If you're able to test it and confirm it fixes the crash, that would be useful.

Comment 14

[Edoardo Panfili]

2 tests, all OK. 

thank you.

Comment 15

[Mark Banner (:standard8)]

(In reply to comment #14)
> 2 tests, all OK. 
> 
> thank you.

Thanks for the confirmation.

Comment 16

[Mark Banner (:standard8)]

Checked in on 1.9.2 for RC 1 build 2:

http://hg.mozilla.org/releases/comm-1.9.2/rev/f0b1abb36c4b
http://hg.mozilla.org/releases/comm-1.9.2/rev/f89b5c30c99c

Comment 17

[Shane Caraveo (:mixedpuppy)]

Looks like we're still seeing this in 3.1:

http://crash-stats.mozilla.com/report/index/e804acc5-b214-4151-a2c5-9fb6d2100602

Comment 18

[David :Bienvenu]

My mistake - that was 3.1 rc1 build 1, and this was fixed in a later build