567175 - An add-on with an invalid target application id can be installed

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

With an install.rdf as follows

<?xml version="1.0"?>
<RDF xmlns="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
  xmlns:em="http://www.mozilla.org/2004/em-rdf#">
  <Description about="urn:mozilla:install-manifest">
    <em:id>[e-mail]</em:id>
    <em:version>2.0</em:version>
    <em:bootstrap>true</em:bootstrap>
    <em:name>test1</em:name>
    <em:description>Test Description</em:description>
    <em:targetApplication>
      <Description>
        <em:id>undefined</em:id>
        <em:minVersion>1.0</em:minVersion>
        <em:maxVersion>99.0</em:maxVersion>
      </Description>
    </em:targetApplication>
  </Description>
</RDF>

AddonManager.getInstallForFile(xpiFile, function(install) {
  install.install();
});

The following was in the error console

Error: this.unloadBootstrapScope is not a function
Source File: file:///d:/moz/_1_mozilla-central/ff-opt/dist/bin/modules/XPIProvider.jsm
Line: 3927

which should actually be self.unloadBootstrapScope

Comment 1

[Robert Strong (they/them - no direct email)]

actually it should be XPIProvider.unloadBootstrapScope

Comment 2

[Robert Strong (they/them - no direct email)]

and it appears that fixing that also fixes bug 567184 though I could be wrong due to lack of sleep.

Comment 3

[Dave Townsend [:mossop]]

It doesn't look to me like we used to validate the target application ID at all so I'm not sure we should start to do so now: http://mxr.mozilla.org/mozilla1.9.2/source/toolkit/mozapps/extensions/src/nsExtensionManager.js.in#3688

Presumably bug 567184 made it so it was no longer installing enabled yes?

Comment 4

[Dave Townsend [:mossop]]

Attachment: patch rev 1

Came across a remaining problem where if a new bootstrapped extension was detected during startup and it was incompatible its startup method would still get called. Fixed that and added tests for the startup and install while running cases.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 454283 [details] [diff] [review]
patch rev 1

Makes sense

Comment 6

[Dave Townsend [:mossop]]

Landed: http://hg.mozilla.org/mozilla-central/rev/eed1e733ca10

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.3a6pre) Gecko/20100625 Minefield/3.7a6pre