567186 - When possible, set viewport size before page finishes loading

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Most pages in Fennec start loading at one size, and then are resized based on the viewport settings after they finish loading.  This is visible to the user.

This patch uses a new event DOMMetaAdded event to update the viewport settings as early as possible.  This eliminates most of the cases where the page resizes after loading.  (It still happens on sites with mobile doctypes rather than meta tags, like http://m.facebook.com/ .)

This depends on the platform patch in bug 567183.  All viewport test cases still pass with these patches applied.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 446547 [details] [diff] [review]
patch

>diff -r cb2ce50de901 chrome/content/browser.js

>+
>+    this._browserViewportState.metaData = null;
>+    this.updateViewportSize();

Why do you call this.updateViewportSize after you reset the metaData? In updateViewportSize you'll hit the empty object for metaData, right?

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to comment #1)
> Why do you call this.updateViewportSize after you reset the metaData? In
> updateViewportSize you'll hit the empty object for metaData, right?

This resets the default viewport settings, so if the new page does not set use <meta name="viewport"> it will start rendering at the default settings, instead of the previous page's settings.

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/b55a406e4297

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a6pre) Gecko/2010614 Namoroka/3.7a6pre Fennec/2.0a1pre