Created attachment 446729 [details] [diff] [review] patch
Comment on attachment 446729 [details] [diff] [review] patch r=me with one question: >+ if (optionAcc) >+ aSelectedAccessibles->AppendElement(static_cast<nsIAccessible*>(optionAcc), Does this static_cast to an nsIAccessible also hurt performance? Can we get rid of this and the ones I saw in some other places in some way if this improves perf?
Attachment #446729 - Flags: review?(marco.zehe) → review+
We can't get rid since AppendElement requires nsISupports* and nsAccessible* is casted to nsISupports* ambiguously. Therefore I cast it to nsIAccessible* so that it's casted to nsISupports* automatically.
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/905ffc9a198d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.