Closed Bug 567369 Opened 10 years ago Closed 10 years ago

GetAccessibleInWeakShell should return nsAccessible*

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #446729 - Flags: review?(marco.zehe)
Attachment #446729 - Flags: review?(bolterbugz)
Comment on attachment 446729 [details] [diff] [review]
patch

r=me with one question:
>+  if (optionAcc)
>+    aSelectedAccessibles->AppendElement(static_cast<nsIAccessible*>(optionAcc),

Does this static_cast to an nsIAccessible also hurt performance? Can we get rid of this and the ones I saw in some other places in some way if this improves perf?
Attachment #446729 - Flags: review?(marco.zehe) → review+
We can't get rid since AppendElement requires nsISupports* and nsAccessible* is casted to nsISupports* ambiguously. Therefore I cast it to nsIAccessible* so that it's casted to nsISupports* automatically.
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/905ffc9a198d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #446729 - Flags: review?(bolterbugz)
You need to log in before you can comment on or make changes to this bug.