GetAccessibleInWeakShell should return nsAccessible*

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 446729 [details] [diff] [review]
patch
Attachment #446729 - Flags: review?(marco.zehe)
Attachment #446729 - Flags: review?(bolterbugz)

Comment 1

9 years ago
Comment on attachment 446729 [details] [diff] [review]
patch

r=me with one question:
>+  if (optionAcc)
>+    aSelectedAccessibles->AppendElement(static_cast<nsIAccessible*>(optionAcc),

Does this static_cast to an nsIAccessible also hurt performance? Can we get rid of this and the ones I saw in some other places in some way if this improves perf?
Attachment #446729 - Flags: review?(marco.zehe) → review+
(Assignee)

Comment 2

9 years ago
We can't get rid since AppendElement requires nsISupports* and nsAccessible* is casted to nsISupports* ambiguously. Therefore I cast it to nsIAccessible* so that it's casted to nsISupports* automatically.
(Assignee)

Comment 3

9 years ago
landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/905ffc9a198d
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Attachment #446729 - Flags: review?(bolterbugz)
You need to log in before you can comment on or make changes to this bug.