567391 - when in the ungrouped group, opening a new tab hides all other tabs

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect)

Description

[Dietrich Ayala (:dietrich)]

this is on trunk.

STR:

1. open tabcandy, click on an ungrouped tab
2. you're now in browser view, with all ungrouped tabs open
3. ctl+t to open a new tab

expected: new tab opens to the right of the open tabs

actual: new tab opens and all other tabs are gone

Comment 1

[Ian Gilman [:iangilman]]

I agree this is no good. 

It happens because the "new tabs" group and the ungrouped tabs are treated as separate sections, but when you create a new tab in the ungrouped tabs section, it goes into the "new tabs" group. 

To fix this, probably the thing to do is to combine those two sections as far as the tab bar is concerned. 

The other possibility, as far as I can tell, is to get rid of the "new tabs" group entirely. 

Assigning to Aza for deliberation.

Comment 2

[Aza Raskin [:aza]]

There is some serious design work that still has yet to take place for the first-run experience. It is being tracked in the Etherpad.

Comment 3

[Aza Raskin [:aza]]

This bug will be fixed by the implementation of #574875

Comment 4

[Ian Gilman [:iangilman]]

(In reply to comment #3)
> This bug will be fixed by the implementation of #574875

I disagree. It'll be mitigated, since people won't be thrust into this situation immediately, but we'll still have the schism wherein tabs created while in the "ungrouped" group will magically whisk you away to the "new tabs" group. This should be fixed.

Comment 5

[Aza Raskin [:aza]]

(In reply to comment #4)
I believe these are now all answered by these two specs:

https://wiki.mozilla.org/Firefox/Projects/TabCandy/Design/FirstRun
https://wiki.mozilla.org/Firefox/Projects/TabCandy/Design/NewTabs

In particular, we won't have a new tabs group and tabs are rarely orphaned for long.

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

From IRC, the "correct behavior", as confirmed by Aza:

"If all orphan tabs show up together in the tab bar, when you create a new tab and that new tab and the last active orphan tab become a group (as I implemented yesterday), then all the other orphan tabs would disappear from the tab bar suddenly?
So I think it would be preferred to make it so that, if you're viewing an orphan tab, the tab bar is just that single tab."

Comment 7

[Dietrich Ayala (:dietrich)]

Ok, thanks. I'll try a build soon and verify.

Comment 8

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".