Closed
Bug 567451
Opened 14 years ago
Closed 14 years ago
Inline some hot paths
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
4.06 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
These show up in Shark profiles and really shouldn't...
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #446807 -
Flags: review?(jst)
Comment 2•14 years ago
|
||
How about we just stick an mGlobalJSObject on nsIScriptGlobalObject, and make nsIScriptGlobalObject::GetGlobalJSObject inline and non-virtual? Then we wouldn't need this "fast" method, right?
Comment 3•14 years ago
|
||
(All that as a possible followup.)
Assignee | ||
Comment 4•14 years ago
|
||
Yeah, I'd rather do that as a followup, especially because nsIScriptGlobalObject is supposed to be language agnostic...
Comment 5•14 years ago
|
||
(In reply to comment #4) > > nsIScriptGlobalObject is supposed to be language agnostic... can we dispense with this agnosticism? it has ended up really costing us. At this point we have a lot platform that depends on JS anyway.
Assignee | ||
Comment 6•14 years ago
|
||
My only reservation about undoing that work is that we did sort of make a big deal of making it part of the platform at the time. This is a bigger question than can really be answered in this bug.
Comment 7•14 years ago
|
||
Mark, is the Python DOM stuff Working? Used? Owned? If none of the above, it is going to go. If two out of three we can talk. If one out of three, especially !Working but kinda-Used, then it's in trouble. /be
Comment 8•14 years ago
|
||
> especially because nsIScriptGlobalObject is supposed to be language agnostic
I'm not suggesting we remove the language-agnostic global object getter. Just that we special-case the JS one, which we use extensively.
I would also be just fine with inlining the language-agnostic one on nsIScriptGlobalObject, honestly.
Comment 9•14 years ago
|
||
AFAIK, sadly Python DOM is languishing - no regular users I am aware of, and AFAIK I remain the default owner although haven't touched it for years now.
Comment 10•14 years ago
|
||
My hope with PyDOM was to get people using true Python (C-Python) in lieu of JS. But the problem is no other browser offers such a thing. IronPython in the DLR on Silverlight scripting the IE DOM -- not the same! Mark, if you are ok with it (hg will remember), we will rip it out in an orderly fashion. We should have a newsgroup post about this. You game? /be
Comment 11•14 years ago
|
||
Separate bug needed. /be
Updated•14 years ago
|
Attachment #446807 -
Flags: review?(jst) → review+
Assignee | ||
Comment 12•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/0dab54516a5a
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Comment 13•14 years ago
|
||
(In reply to comment #11) > Separate bug needed. bug 570738.
Comment 14•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0dab54516a5a
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•