Update Webtrends JS to support our download types

VERIFIED FIXED in 5.11

Status

addons.mozilla.org Graveyard
Public Pages
P1
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: fligtar, Assigned: clouserw)

Tracking

Details

(Reporter)

Description

8 years ago
Please replace this line of our webtrends.js

this.downloadtypes="xls,doc,pdf,txt,csv,zip,dmg,exe";

with

this.downloadtypes="xpi,jar";

on both [z] and [r]
(Assignee)

Updated

8 years ago
Assignee: nobody → clouserw
(Assignee)

Comment 1

8 years ago
r67574

http://github.com/jbalogh/zamboni/commit/0f5c747ab65eaa1e95e2522a50f3af0f79bfbf16
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You didn't replace, you appended (but I guess that's not a problem?)

https://preview.addons.mozilla.org/media/js/webtrends/webtrends-v0.1.js:

this.downloadtypes="xls,doc,pdf,txt,csv,zip,dmg,exe,xpi,jar";
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> You didn't replace, you appended (but I guess that's not a problem?)

I didn't want to have to edit it again when we start offering a csv download or something.
Cool; verified FIXED (just doing my job!)
Status: RESOLVED → VERIFIED
(Reporter)

Comment 5

8 years ago
I don't want CSVs to count as downloads, and please tell me if you mark a bug fixed and alter the fix.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

8 years ago
r67692
http://github.com/jbalogh/zamboni/commit/abbeb5a97dc60c8b672ff366f14935af6ebe8e47
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Sorry for comment 4; I shouldn't have assumed...

Verified FIXED.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.