567487 - Option to never remember history should disable the option to restore the last session

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

User on dev-usability writes:

>When I choose
>'Never remember history' and
>'When Firefox starts: Show my windows and tabs from last time',
>it won't  show last session.

These two options are mutually exclusive, we should give the privacy setting precedence and disable the start up option when the user has indicated that Firefox should never remember history.

Comment 1

[Alex Faaborg [:faaborg] (Firefox UX)]

Note that we would also need some indication of why the option was disabled.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

In this patch, if pb.autostart is enabled, I disable the 'Show my windows and tabs from last time' option, but do not change the underlying pref value (in case the user later turns pb.autostart off).

If the value of browser.startup.page is 3 and pb.autostart is enabled, I select the value 1 in the menu list, but don't touch the underlying pref value (which is ignored in reality anyway.)

Comment 3

[(no longer active)]

gavin: ping?

Comment 4

[(no longer active)]

gavin: reping?

Specifically, if we don't take this until the feature freeze, it will slip to Firefox Next.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 447468 [details] [diff] [review]
Patch (v1)

It's kind of odd that the menu will show an item that doesn't reflect the pref, and that re-selecting the selected menu item will actually change the pref, but I don't know if there are any better options. Get ui-review, perhaps?

Comment 6

[Alex Limi (:limi) — Firefox UX Team]

Comment on attachment 447468 [details] [diff] [review]
Patch (v1)

It's a bit weird, agreed — but it's also an edge case, so should be fine overall.

Comment 7

[(no longer active)]

Beltzner: since this can be considered as an interaction change, beta7 is our last chance to take this for Firefox 4.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 447468 [details] [diff] [review]
Patch (v1)

This is an edge case - it could land later than beta 7, IMO.

Comment 9

[(no longer active)]

(In reply to comment #8)
> Comment on attachment 447468 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=447468
> Patch (v1)
> 
> This is an edge case - it could land later than beta 7, IMO.

Do you mean that it _should_ land after beta 7, or that if it doesn't get to beta 7, the universe will not end and the human race will not be extinct?

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I mean that I don't think there are any special constraints on when this lands :)

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/8e7511b71f59