Closed Bug 567487 Opened 11 years ago Closed 11 years ago

Option to never remember history should disable the option to restore the last session

Categories

(Firefox :: Private Browsing, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b7

People

(Reporter: faaborg, Assigned: ehsan)

References

Details

(Keywords: ux-error-prevention)

Attachments

(1 file)

User on dev-usability writes:

>When I choose
>'Never remember history' and
>'When Firefox starts: Show my windows and tabs from last time',
>it won't  show last session.

These two options are mutually exclusive, we should give the privacy setting precedence and disable the start up option when the user has indicated that Firefox should never remember history.
Note that we would also need some indication of why the option was disabled.
Attached patch Patch (v1)Splinter Review
In this patch, if pb.autostart is enabled, I disable the 'Show my windows and tabs from last time' option, but do not change the underlying pref value (in case the user later turns pb.autostart off).

If the value of browser.startup.page is 3 and pb.autostart is enabled, I select the value 1 in the menu list, but don't touch the underlying pref value (which is ignored in reality anyway.)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #447468 - Flags: review?(gavin.sharp)
Flags: in-litmus?
gavin: ping?
gavin: reping?

Specifically, if we don't take this until the feature freeze, it will slip to Firefox Next.
Comment on attachment 447468 [details] [diff] [review]
Patch (v1)

It's kind of odd that the menu will show an item that doesn't reflect the pref, and that re-selecting the selected menu item will actually change the pref, but I don't know if there are any better options. Get ui-review, perhaps?
Attachment #447468 - Flags: review?(gavin.sharp) → review+
Attachment #447468 - Flags: ui-review?
Attachment #447468 - Flags: ui-review? → ui-review?(faaborg)
Comment on attachment 447468 [details] [diff] [review]
Patch (v1)

It's a bit weird, agreed — but it's also an edge case, so should be fine overall.
Attachment #447468 - Flags: ui-review?(faaborg) → ui-review+
Attachment #447468 - Flags: approval2.0?
Beltzner: since this can be considered as an interaction change, beta7 is our last chance to take this for Firefox 4.
Comment on attachment 447468 [details] [diff] [review]
Patch (v1)

This is an edge case - it could land later than beta 7, IMO.
Attachment #447468 - Flags: approval2.0? → approval2.0+
(In reply to comment #8)
> Comment on attachment 447468 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=447468
> Patch (v1)
> 
> This is an edge case - it could land later than beta 7, IMO.

Do you mean that it _should_ land after beta 7, or that if it doesn't get to beta 7, the universe will not end and the human race will not be extinct?
I mean that I don't think there are any special constraints on when this lands :)
http://hg.mozilla.org/mozilla-central/rev/8e7511b71f59
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b7
Flags: in-litmus?
You need to log in before you can comment on or make changes to this bug.