There are currently a number of strict js warnings popping up in the code in stringbundleBindings.xml, using this bug to track fixes.
I'll work on a test case for this bug :-) With this patch applied there's one warning left, caused by a bug in the checking code, see bug 49233 for a patch there.
r=ben for the strict warnings.
email@example.com. Sometimes you can avoid the existing bogus strict warning by moving the "usual" or "expected" return out of the try and to the end of the function. But I agree in this case that it's better to return from within the try, matching the catch return in indentation and apparent control flow. /be
Yeah, but sometimes it's just better to fix than to avoid :-) Put the testcase in comm.jar in content/navigator/foo.xul and load it with chrome://navigator/content/foo.xul Upon loading the testcase in a debug build, I see on the console: [Unfixed] line 9: function getString does not always return a value line 9: function onset does not always return a value line 2: assignment to undeclared variable strBundleService line 3: assignment to undeclared variable localeService [Fixed] line 9: function getString does not always return a value That last warning should go away when the (currently) latest patch to bug 49233 is checked in.
Checked this in, marking fixed.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.