567521 - winEmbed can't be built since Apr 29 (Windows XULRunner nightlies missing for mozilla-central)

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: MFC Embed, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

[I really want Core:: Embedding: winEmbed but I trust someone will put this in the right place

Somewhere in http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=797e4ee41b51&tochange=c9212eb6175b
was a change that caused:
link -NOLOGO -OUT:winEmbed.exe -PDB:winEmbed.pdb  -NXCOMPAT -DYNAMICBASE -SAFESEH  -DEBUG -DEBUGTYPE:CV -MANIFEST:NO -LIBPATH:"e:/builds/moz2_slave/mozilla-central-win32-xulrunner/build/obj-firefox/memory/jemalloc/crtsrc/build/intel" -NODEFAULTLIB:msvcrt -NODEFAULTLIB:msvcrtd -NODEFAULTLIB:msvcprt -NODEFAULTLIB:msvcprtd -DEFAULTLIB:mozcrt19 -DEFAULTLIB:mozcpp19 -DEBUG -OPT:REF   /HEAP:0x40000 winEmbed.obj WebBrowserChrome.obj WindowCreator.obj winEmbed.res ../../../profile/dirserviceprovider/standalone/profdirserviceprovidersa_s.lib e:/builds/moz2_slave/mozilla-central-win32-xulrunner/build/obj-firefox/dist/lib/xpcomglue.lib   kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib ole32.lib comdlg32.lib shell32.lib version.lib
profdirserviceprovidersa_s.lib(nsProfileDirServiceProvider.obj) : error LNK2019: unresolved external symbol "struct already_AddRefed<class nsIObserverService> __cdecl mozilla::services::GetObserverService(void)" (?GetObserverService@services@mozilla@@YA?AU?$already_AddRefed@VnsIObserverService@@@@XZ) referenced in function "public: virtual unsigned int __thiscall nsProfileDirServiceProvider::Shutdown(void)" (?Shutdown@nsProfileDirServiceProvider@@UAEIXZ)
winEmbed.exe : fatal error LNK1120: 1 unresolved externals
make[5]: Leaving directory `/e/builds/moz2_slave/mozilla-central-win32-xulrunnermake[5]: *** [winEmbed.exe] Error 96

This causes the nightlies for xulrunner to fail on win32. Bug 560095 looks like a likely target.

Comment 1

[Mitchell Field [:Mitch]]

Attachment: Patch v1

This patch might fix it.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 447897 [details] [diff] [review]
Patch v1

pushed this as 
https://hg.mozilla.org/mozilla-central/rev/04699f5bf844

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #1)
> Created an attachment (id=447897) [details]
> Patch v1
> 
> This patch might fix it.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Green: http://tinderbox.mozilla.org/showlog.cgi?log=XULRunner/1275083701.1275093106.18499.gz&fulltext=1