"Other add-ons by" not showing for authors with exactly two add-ons

VERIFIED FIXED in 5.11

Status

defect
VERIFIED FIXED
9 years ago
3 years ago

People

(Reporter: davemgarrett, Assigned: landas)

Tracking

unspecified
5.11

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
"Other add-ons by" dropdown shows for instance of a couple dozen add-ons:
https://preview.addons.mozilla.org/z/en-US/firefox/addon/4609/

shows fine with links for four add-ons total:
https://preview.addons.mozilla.org/z/en-US/firefox/addon/1865/
or three add-ons total:
https://preview.addons.mozilla.org/z/en-US/firefox/addon/2410/

but nothing here:
https://preview.addons.mozilla.org/z/en-US/firefox/addon/5791/
or here:
https://preview.addons.mozilla.org/z/en-US/firefox/addon/722/

We each have two add-ons and the "Other add-ons by" section isn't showing. Happens on both preview and production.
(Assignee)

Comment 1

9 years ago
Posted patch patchSplinter Review
Confirming. $authorAddons is only containing other authorAddons than displayed on page.

Patch added.
Attachment #447015 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #447015 - Flags: review? → review?(clouserw)
Comment on attachment 447015 [details] [diff] [review]
patch

I think this originally came from expecting the list to contain all add-ons by the author, so it was removing the 1 for the page you're on.  Not a great assumption. :)

I'm r-ing because you've modified the PHP code, but these pages are served by python now (you can tell by the /z/ in the URLs).  If you're interested in making a new patch, we'd be happy to have the help.  The equivalent template in zamboni is at http://github.com/jbalogh/zamboni/blob/master/apps/addons/templates/addons/details.html and the variable is author_addons.
Attachment #447015 - Flags: review?(clouserw) → review-
(Assignee)

Comment 3

9 years ago
I forked a version to work on, and did a "pull request" with my changes in the webinterface.

Is this the correct way to do it. I added you as a recipient in the pull request.
It's perfect.  I added comments on your branch.
Assignee: nobody → landas
Target Milestone: --- → 5.11
http://github.com/jbalogh/zamboni/commit/6e69ddc39637eaac8215fd902b58706da9b2a57d

Thanks.  QA:  The URLs in comment 0 will have an "Other add-ons by" section now, even if there is only 1 add-on in it.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED, on the last two URLs in comment 0.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.