Closed
Bug 567671
Opened 14 years ago
Closed 12 years ago
Test::Taint throws a warning every time it's loaded, on perl 5.10, and makes errors into test failures
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: mkanat, Assigned: LpSolit)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
668 bytes,
patch
|
dkl
:
review+
Wurblzap
:
review+
|
Details | Diff | Splinter Review |
Test::Taint throws a warning every time it's loaded, on perl 5.10, and the maintainer isn't doing anything about it.
|
Assignee | |
Comment 1•14 years ago
|
||
btw, why do you report it on bmo? That's not our module.
|
Reporter | |
Comment 2•14 years ago
|
||
Here's a fairly simple fix. Right now, I think that this will only go on trunk, since it wouldn't be good of us to change Requirements on people mid-branch.
|
|
Reporter | |
Comment 3•14 years ago
|
||
I'm not sure what your question about bmo is.
Summary: Test::Taint throws a warning every time it's loaded, on perl 5.10 → Test::Taint throws a warning every time it's loaded, on perl 5.10, and makes errors into test failures
|
|
Assignee | |
Comment 4•14 years ago
|
||
My question was: why reporting a bug on bmo which is not a Bugzilla bug? You already reported it to rt.cpan.org. IMO, the bug summary should be: "stop using Test::Taint, because it throws warnings on Perl 5.10".
|
|
Reporter | |
Comment 5•14 years ago
|
||
Oh. Well, I figure the bug is that it throws warnings and loads Test::More, our fix for it is to stop using it. I usually figure bug summaries should describe the problem, not the solution. The checkin message can describe the solution.
|
|
Assignee | |
Comment 6•14 years ago
|
||
(In reply to comment #2) > Right now, I think that this will only go on trunk, since it wouldn't be good > of us to change Requirements on people mid-branch. Or we could relnote in 3.6.1 that we plan to replace Test::Taint by Taint::Util in 3.6.2, so that people already know about this story well before upgrading.
|
|
Reporter | |
Comment 7•14 years ago
|
||
Comment on attachment 446984 [details] [diff] [review] v1 We don't need this anymore--the RPC::Any bug supersedes this.
Attachment #446984 -
Flags: review?(LpSolit)
|
|
Reporter | |
Updated•14 years ago
|
Depends on: bz-rpc-any
Whiteboard: [blocker will fix]
|
|
Assignee | |
Comment 8•13 years ago
|
||
We won't take RPC::Any for 4.0.
Target Milestone: Bugzilla 3.6 → Bugzilla 4.2
|
|
Assignee | |
Updated•12 years ago
|
Assignee: mkanat → general
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → NEW
|
|
Assignee | |
Comment 9•12 years ago
|
||
Test::Taint 1.06 has been released to fix this specific bug.
Assignee: general → LpSolit
Status: NEW → ASSIGNED
Whiteboard: [blocker will fix]
Target Milestone: Bugzilla 4.2 → Bugzilla 5.0
|
|
Assignee | |
Comment 10•12 years ago
|
||
Attachment #446984 -
Attachment is obsolete: true
Attachment #686222 -
Flags: review?(justdave)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #686222 -
Flags: review?(dkl)
|
||
Comment 11•12 years ago
|
||
Comment on attachment 686222 [details] [diff] [review] patch, v2 Review of attachment 686222 [details] [diff] [review]: ----------------------------------------------------------------- r=dkl by inspection
Attachment #686222 -
Flags: review?(dkl) → review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #686222 -
Flags: review?(justdave)
|
||
Comment 12•12 years ago
|
||
Comment on attachment 686222 [details] [diff] [review] patch, v2 Fwiw, r=Wurblzap by inspection, too. I came accross this in bug 784072.
Attachment #686222 -
Flags: review+
|
|
Assignee | |
Comment 13•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/ modified Bugzilla/Install/Requirements.pm Committed revision 8505.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•