56789 - Add more build logic for the LDAP component on Mac

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Peter Van der Beken]

The attached patch adds build logic for installing the LDAP datasource and the 
tests. Looking for review. Assigned to JJ (hopefully he's back from sabbatical, 
otherwise please reassign).

Comment 1

[Peter Van der Beken]

Attachment: Diff for build script

Comment 2

[Peter Van der Beken]

Attachment: mozilla/directory/xpcom/tests/MANIFEST

Comment 3

[J.J. Enser]

looks good to me, eventhough I have missed this topic while I was on vacation.
by default options{ldap} is turned off. who uses it?

Jon, Simon, what do you think?

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

I do.  And hopefully ldap will get turned on by default in the builds eventually.

Comment 5

[J.J. Enser]

Peter, Dan, is still issue still open?
If so, I'm ok to add the 2 patches to the trunk, (patch #1 will have to be 
applied to NetscapeBuildList.pm instead of NGLayoutBuildList.pm)

Who should approve this chckin?

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

I think sfraser's new build system already copes with LDAP nicely.  I suspect
this can be closed. sfraser?

Comment 7

[Simon Fraser [no longer active]]

If you set 'options ldap 1' in your prefs file, LDAP should build. I've not 
tested it, but the build code is there.

Comment 8

[Peter Van der Beken [:peterv]]

Hold on, this patch is for installing the datasource component file
(nsLDAPDataSource.js). Though it is diff'ed against the old build script, it
should still be added to the new build scripts. I'll attach an update.

Comment 9

[J.J. Enser]

Did LDAP make it into the build script already ? Just checking since this seems 
to be *my* bug :-)  no recent activity though

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Basic LDAP stuff (not including the datasource) were turned on in the default
build last week.  I suspect these patches may need to be tweaked to compensate.
 Peter?

Comment 11

[Peter Van der Beken [:peterv]]

Attachment: Updated patch

Comment 12

[Peter Van der Beken [:peterv]]

I've attached an updated patch, we only need the last one. I'll take this.
Looking for r and sr.

Comment 13

[Simon Fraser [no longer active]]

Man, having an 'xpcom' directory in mozilla/directory always throws me. Bad idea!

sr=sfraser on the last patch.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers)

Comment 15

[Peter Van der Beken [:peterv]]

Checked in.

Comment 16

[Jon Granrose]

verified.