Enable JIT verbose output for release debugger builds

RESOLVED FIXED

Status

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: rreitmai, Unassigned)

Tracking

Details

(Whiteboard: fixed-in-tracemonkey, fixed-in-tamarin, fixed-in-nanojit)

Attachments

(1 attachment)

Somewhere along the line -Dverbose=jit was disabled for all non-debug builds.  This means that we can no longer see jit generated verbose output unless we build a debug build, which is very inconvenient.

Also, the define NJ_VERBOSE_DISABLED was introduced without a corresponding ifdef around the JIT verbose flags of the shell which leads one to erroneously assume that methods are not being JIT'd (no output visible).

As the verbose mechanism in the JIT adds less than 2% to overall size (measured on xcode built x86-32 shell) , recommend adding it back.

If this is not acceptable (and/or we retain the NJ_VERBOSE_DISABLED define) then we need to fix the verbose flags parsing to report an error.
Posted patch enable it Splinter Review
Attachment #447225 - Flags: review?(stejohns)
Attachment #447225 - Flags: review?(stejohns) → review+
pushed http://hg.mozilla.org/tamarin-redux/rev/c26013c9f7df
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-tracemonkey → fixed-in-tracemonkey, fixed-in-tamarin, fixed-in-nanojit
You need to log in before you can comment on or make changes to this bug.