567925 - Breadcrumbs for add-ons with lengthy names look awkward

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P4)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
Notice the breadcrumb for the add-on-https://preview.addons.mozilla.org/en-US/firefox/addon/9412/

observed behavior:
Breadcrumbs for add-ons with lengthy names look awkward.See screenshot.This would look worse once we add breadcrumbs to EULA and versionHistory pages

Comment 1

[Justin Scott [:fligtar]]

We should truncate long add-on names with an ellipsis in breadcrumbs. A little trail of breadcrumbs within breadcrumbs, if you will.

Let's say 40 characters.

Comment 2

[Wil Clouser [:clouserw]]

Edmund, want to check this out?  Looks like jinja has a truncate function:

http://jinja.pocoo.org/2/documentation/templates

Comment 3

[Edmund Wong (:ewong)]

Attachment: Shortened addon description in the addon breadcrumb up to the 40th character and then used ellipses

Comment 4

[Jeff Balogh (:jbalogh)]

Comment on attachment 450657 [details] [diff] [review]
Shortened addon description in the addon breadcrumb up to the 40th character and then used ellipses


> {% block content %}
>-{{ breadcrumbs([(addon.type.get_url_path(), amo.ADDON_TYPES[addon.type_id]), (None, addon.name)]) }}
>+{% set addonname = "%s" % addon.name %}

jinja has the |str filter for this.

>+{% set addonname = addonname | truncate(40, True, '...') %}

You only need to pass in the length; the other arguments can be left with their defaults.

>+{{ breadcrumbs([(addon.type.get_url_path(), amo.ADDON_TYPES[addon.type_id]), (None, addonname )]) }}

It's slightly cleaner to use a {% with %} so your new variable is only in a small scope.

{% with name=addon.name|str|truncate(40) %}
  {{ breadcrumbs(...) }}
{% endwith %}

Comment 5

[Edmund Wong (:ewong)]

Attachment: Shortened addon description in the addon breadcrumb up to the 40th character and then used ellipses (v2)

Comment 6

[Wil Clouser [:clouserw]]

Thanks!  I made a couple slight adjustments to bring it up to to date with the code.  http://github.com/jbalogh/zamboni/commit/9686298a9dd5e17a2c919e96c40be515624fadb6

Comment 7

[Wil Clouser [:clouserw]]

So, it occurs to me after the fact :-/ that this will only work on single add-on pages and not any of the sub pages, etc.  Instead of the single fix in the patch above, we should edit apps/amo/helpers.py:breadcrumbs() to add a default truncate=40 kwarg and have it affect all portions of the breadcrumbs.

Comment 8

[Wil Clouser [:clouserw]]

stealing from ewong!

Comment 9

[Barry Chen]

Committed @ https://github.com/chenba/zamboni/commit/700da06c8597df10b7f42068a83d9ecbc183ba41

Comment 10

[Wil Clouser [:clouserw]]

looks good, please land

Comment 11

[Barry Chen]

Now in jbalogh/master: https://github.com/jbalogh/zamboni/commit/00efa1df3e279fa6a99a8e59827881fbd226bf1b

Comment 12

[krupa raj[:krupa]]

verified FIXED at-

https://addons.allizom.org/de/firefox/addon/11166/
https://addons.allizom.org/de/firefox/addon/11166/reviews/
https://addons.allizom.org/en-US/firefox/addon/11166/privacy/
https://addons.allizom.org/en-US/firefox/addon/11166/versions/
https://addons.allizom.org/he/firefox/addon/11166/license/1.0.5

Comment 13

[krupa raj[:krupa]]

Attachment: post-fix screenshot