Add build logic for jarring component viewer chrome component on Mac

VERIFIED FIXED in mozilla0.6

Status

SeaMonkey
Build Config
P3
blocker
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Peter Van der Beken, Assigned: cls)

Tracking

({smoketest})

Trunk
mozilla0.6
smoketest

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(8 attachments)

(Reporter)

Description

18 years ago
Ataching a patch and necessary files so component viewer gets jar'ed. Looking 
for review.
(Reporter)

Comment 1

18 years ago
Created attachment 17232 [details] [diff] [review]
Patch for build logic (mac/unix/win)
(Reporter)

Comment 2

18 years ago
Created attachment 17233 [details]
mozilla/extensions/cview/jar.mn
(Reporter)

Comment 3

18 years ago
Created attachment 17234 [details]
mozilla/extensions/cview/resources/content/contents.rdf
(Reporter)

Comment 4

18 years ago
Created attachment 17235 [details]
mozilla/extensions/cview/resources/locale/en-US/contents.rdf
(Reporter)

Comment 5

18 years ago
Created attachment 17236 [details]
mozilla/extensions/cview/resources/skin/contents.rdf
(Reporter)

Updated

18 years ago
Keywords: review
Summary: Add build logic for jarring component viewer chrome component on Mac → Add build logic for jarring component viewer chrome component on Mac
(Assignee)

Comment 6

18 years ago
In the makefiles, could you split up the REGCHROME calls into individual lines?
This has caused problems on OS/2 before.  Other than that, it looks good. r=cls


Status: NEW → ASSIGNED
(Reporter)

Comment 7

18 years ago
Created attachment 17326 [details] [diff] [review]
New patch for build logic (mac/unix/win) - replaces 17232
                                                       Patch for build logic (mac/unix/win)
                                                       Patch for build logic (mac/unix/win)

Comment 8

18 years ago
Peter: have you built with this on Mac?  It looks good to me, but Mac build
changes are tricky and always require testing.  If you haven't built with this
change on Mac, then I'll have to before I can sr=.
(Reporter)

Comment 9

18 years ago
Don't worry Scott, as Mac is my primary platform I always test there first. 
Thanks to both of you for quick response times.
(Reporter)

Comment 10

18 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

18 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 11

18 years ago
Hey,
the checked in jar.mn has some errors, so I tried to fix those. I will attach
my jar.mn right after this. (some whitespace magic, don't know if it's tabs
or trailing whitespace)
I moved the jar.mn to the ressources directory, as that's the place where we
register the chrome, so there is only one dir to build the chrome.
Could somebody review the new jar.mn? I can only test on solaris.

Axel

Comment 12

18 years ago
Created attachment 17767 [details]
new extensions/cview/resources/jar.mn

Comment 13

18 years ago
this apparently broke the mac mozilla trunk verification build.  It started
failing with the 10/22 8pm builds with an error complaining about this jar.mn file.

this is a smoketest blocker.
Severity: normal → blocker
Keywords: smoketest
(Reporter)

Comment 14

18 years ago
Terribly sorry about that. Seems the file got the wrong line endings, not sure 
how that happened. I didn't see the build bustage last night.
You want to back out the change or should I make a patch that fixes this?

Comment 15

18 years ago
patch it and check it in please.
(Reporter)

Comment 16

18 years ago
Fixing this involves checking in attachment 17767 [details] (new extensions/cview/
resources/jar.mn) and the following patch and removing the broken (and misplaced 
extensions/cview/jar.mn).
(Reporter)

Comment 17

18 years ago
Created attachment 17776 [details] [diff] [review]
patch for mac build logic

Comment 18

18 years ago
get it reviewd and check it in, a=granrose.
(Reporter)

Comment 19

18 years ago
Looking for a review from Mac folks. This is a smoketest blocker. See comment at 
2000-10-23 10:00 for fix.

Comment 20

18 years ago
I'm testing this on my mac build now...
Target Milestone: --- → mozilla0.6

Comment 21

18 years ago
sorry; I only took the most recent patch so I need to retest again :-/

Comment 22

18 years ago
I have checked in the fix for the jar.mn file (attached 10/23/00 06:27)
I'm having problems with the 10/23/00 10:02 fix; it doesn't work at all for me 
(do we know that it is supposed to work or is this just a guess at a fix?)
(Reporter)

Comment 23

18 years ago
Ok, I'm gonna check in the real fix. I have verified both debug and opt clobber 
in my tree. The file you fixed should have been removed, and checked in under 
its new path. The patch should then work.
(Reporter)

Comment 24

18 years ago
Fix checked in. Watching Tinderbox before I mark fixed (it'll turn green, I 
promise).
(Reporter)

Comment 25

18 years ago
Marking fixed.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 26

18 years ago
verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.