56795 - Add support for corel/eazel profiler

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Ramiro Estrugo]

The corel/eazel profiler can be used with mozilla.  All that is needed are a few
configure changes.

Comment 1

[Ramiro Estrugo]

Attachment: Patch to add corel/linux profiler support on linux

Comment 2

[Ramiro Estrugo]

Adding [e-mail] to cc.

I attatched the configure voodoo patch.  It adds support for the new profiler
and removes the old gprof cruft which never worked.

Comment 3

[Ramiro Estrugo]

Id like to check this in soon.  I've tested it, and there are some issues on the
profiler side of things which Ill work on.  However, it will suck if this code
bit rots as configure changes tend to do.

Comment 4

[Christopher Blizzard (:blizzard)]

This look OK to me.  But, really, it's all cls to get this reviewed since
building is his baby.

Comment 5

[cls]

Are we sure that no one's using --enable-profile?  Rich, since the option is
labelled as solaris only, do you know of anyone who's actively using it (or if
the option still works)?

Also, do we really need the hardcoded -L/gnome/PROFILE/lib path?

Comment 6

[Ramiro Estrugo]

I can fix the -L/gnome/profile hack.  Yes, its a dumb leftover.  I intend to
provide an rpm of the profiler, so there will be no need for -L flags.

About solaris, i really doubt that gprof worked there.  As far as I could tell
the --enable-profiler flag was completely broken and all it did was complicate
the configure mess even more.  I removed all references to gprof to make the
life of whoever has to come in and hack on this stuff in the future a little
less painful.

Comment 7

[Rich Burridge]

cls: we (the Netscape 6 on Solaris team) currently aren't using it. 
I can't speak for other groups within Sun though (such as the GNOME
integration team or the StarOffice integration team). It might be 
something that would be useful when we have more time to concentrate 
on things like this though, so it would be nice to fix this bug.

Comment 8

[cls]

Ok. r=cls

Comment 9

[Ramiro Estrugo]

Reassigning to myself.

Comment 10

[Ramiro Estrugo]

Marking assigned.

Comment 11

[Tomi Leppikangas]

I think we are running ld-scripts when configured with --enable-optimize?
Ld-scripts stips off all function names -> not much left to profile, and
optimized build is probaply what we usually want to profile. 

So need to hack that doesn't run ld-scripts when profiling is enabled.

Comment 12

[Tomi Leppikangas]

Ok, thas easy, just add:
MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS=
like this:

[  --enable-eazel-profiler          Enable Corel/Eazel profiler],
  [  ENABLE_EAZEL_PROFILER=1
     AC_DEFINE(ENABLE_EAZEL_PROFILER)
     USE_ELF_DYNSTR_GC=
     MOZ_COMPONENTS_VERSION_SCRIPT_LDFLAGS=
     EAZEL_PROFILER_CFLAGS="-g -O -gdwarf-2 -finstrument-functions
-D__NO_STRING_INLINES  -D__NO_MATH_INLINES"
     EAZEL_PROFILER_LIBS="-L/gnome/PROFILE/lib -lprofiler -lpthread"])

Comment 13

[Ramiro Estrugo]

I checked this in with cls' suggestion of removing the hardcoded path and tomi's
suggestion of not stripping symbols out - duh.

marking fixed.

Comment 14

[Jon Granrose]

verified.