Closed Bug 567966 Opened 13 years ago Closed 13 years ago

D3D9 layers are leaking memory

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

Attachments

(2 files)

Part 1: Properly handle siblings and children
7.30 KB, patch
vlad
: review+
Details | Diff | Splinter Review
Part 2: Fix a rogue allocation in YCbCrImageD3D
994 bytes, patch
vlad
: review+
Details | Diff | Splinter Review 
D3D9 layers are leaking memory, the problem is twofold. There's a rogue allocation in YCbCrLayers, and Containers aren't deleting their children in the destructor. Even though they can be deleted while still having children.
This fixes the way ContainerLayerD3D9 treats children and siblings by using the parent class's members for all this. It also properly releases all children.
Attachment #447282 - Flags: review?(vladimir)
Comment on attachment 447282 [details] [diff] [review]
Part 1: Properly handle siblings and children

looks fine, but youch, the sibling stuff needs a refactoring, as you mentioned on irc
Attachment #447282 - Flags: review?(vladimir) → review+
Pushed http://hg.mozilla.org/mozilla-central/rev/d17957dc3ae1.
Pushed http://hg.mozilla.org/mozilla-central/rev/242cafe7bc40.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.