568041 - More layer API needed for retained layers

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Patches coming...

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 1: add user-data API and GetRoot to LayerManager, add mVisibleRegion to Layer

Also fixes a few trivial build warnings in the GL backend.

Right now the retained layer code only stores rects in the visible region, but if I want to change that later I'll need to be able to round-trip the regions that I store.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: refactor RemoveChild

Simplifies BasicContainerLayer::~BasicContainerLayer and ContainerLayerD3D9::~ContainerLayerD3D9 by having them call RemoveLayer.

Also ContainerLayerD3D9::RemoveChild needs to null out the parent/prev-sibling/next-sibling links in all cases. Retained layers depends on us being able to remove a layer and re-add it elsewhere in the layer tree without anything getting confused. It might work with dangling pointers in those fields, but they are confusing.

ContainerLayerOGL needs to be fixed too, but that's harder since it still has the problem of LayerOGL::mNextSibling shadowing Layer::mNextSibling. So I haven't touched it here, I'm hoping someone else will fix that :-).

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 447342 [details] [diff] [review]
Part 1: add user-data API and GetRoot to LayerManager, add mVisibleRegion to Layer

Good stuff!

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/5134171b7a01
http://hg.mozilla.org/mozilla-central/rev/dd0f1f0a96b3