568077 - Missing persona in the vertical carousel on Persona landing page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1.Go to https://preview.addons.mozilla.org/z/en-US/firefox/personas/
2.Notice that the vertical carousel has one missing persona


see screenshot.

Comment 1

[krupa raj[:krupa]]

This is still valid.Just showed the behavior to Jeff.

Comment 2

[Potch [:potch]]

This only happens when the user changes the zoom of the webpage, and then only when it is resized smaller. The easy fix is to hard-code the number of visible items, as the math that figures how many elements are visible at a time is what's being afffected by the resize.

Comment 3

[Jeff Balogh (:jbalogh)]

Are there any overflow/underflow problems if it's hardcoded?

Comment 4

[Potch [:potch]]

no impact other than making the component less re-usable, which makes me sad, but I will do in the name of it working better.

Comment 5

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/d03867d1

Comment 6

[krupa raj[:krupa]]

verified at https://preview.addons.mozilla.org/en-US/firefox/personas/