568089 - TM: rename iteratorAtom -> __iterator__Atom

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Andreas Gal :gal]

For clarity, and also I would like to add an iteratorAtom that means "iterator". Also, I would like to remove js_iterator_str, because js___iterator___str is just too ugly, and its used only twice, and soon we might remove it anyway.

Comment 1

[Andreas Gal :gal]

Attachment: patch

Comment 2

[Andreas Gal :gal]

Attachment: avoid duplicate string by using AtomToPrintableString

Comment 3

[Andreas Gal :gal]

Comment on attachment 447379 [details] [diff] [review]
avoid duplicate string by using AtomToPrintableString

Are you ok with this renaming?

Comment 4

[Jeff Walden [:Waldo]]

Double-underscore-using names are reserved in C++ for the compiler and the standard library implementation.  I don't think we can make this change (although I could be open to something other than iteratorAtom).

Comment 5

[Andreas Gal :gal]

The name doesn't start with double underscore.

Comment 6

[Andreas Gal :gal]

Luke, is __name as a field name ok in C++ or is that somehow reserved? I thought only linker symbols start with _ are funky.

Comment 7

[Jeff Walden [:Waldo]]

__ *anywhere* in the name makes it non-kosher, not just at the start (and not just linker symbols, either).

"Each name that contains a double underscore (__) or begins with an underscore followed by an uppercase letter (2.11) is reserved to the implementation for any use."

ISO C++, 17.4.3.1.2

Comment 8

[Andreas Gal :gal]

I guess that settles it.