Closed
Bug 568155
Opened 14 years ago
Closed 14 years ago
Allow validateOptions to set default values for missing options
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
0.5
People
(Reporter: zpao, Assigned: zpao)
Details
Attachments
(1 file)
|
2.83 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
Currently if you use map to attempt to set a default value but the key wasn't included in the options, then the default value isn't included.
|
Assignee | |
Comment 1•14 years ago
|
||
Like we talked about. Not sure how we do the reviews here, but you can bounce it if need be.
|
||
Comment 2•14 years ago
|
||
Comment on attachment 447467 [details] [diff] [review] Patch v0.1 Looks good, thanks. >+ if (keyInOpts || req.map && !mapThrew) Technically fine of course, but for clarity please add parens around the last two terms. r=adw
Attachment #447467 -
Flags: review?(adw) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed http://hg.mozilla.org/labs/jetpack-sdk/rev/b2745c849c06
Flags: in-testsuite+
Target Milestone: -- → 0.5
|
|
Assignee | |
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 4•14 years ago
|
||
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product. To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Flags: in-testsuite+
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•