Support geolocation on Android

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

Trunk
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
Created attachment 447561 [details] [diff] [review]
Add Geolocation provider for Android
Attachment #447561 - Flags: review?(dougt)

Comment 2

8 years ago
Comment on attachment 447561 [details] [diff] [review]
Add Geolocation provider for Android

This is great!

>+#include "AndroidLocationProvider.h"
>+
>+using namespace mozilla;
Not sure why we need this.  If we do, fine.  If not, lets remove it


>diff --git a/widget/src/android/nsAppShell.cpp b/widget/src/android/nsAppShell.cpp

Is there a way to get notifications outside of the appshell?  This is the first example of having to use the app shell to get geo notifications.  If not, thats fine.
Attachment #447561 - Flags: review?(dougt) → review+
(Assignee)

Comment 3

8 years ago
(In reply to comment #2)
> >+#include "AndroidLocationProvider.h"
> >+
> >+using namespace mozilla;
> Not sure why we need this.  If we do, fine.  If not, lets remove it
> 
It's used so we don't have to do mozilla:: when using AndroidBridge.

> >diff --git a/widget/src/android/nsAppShell.cpp b/widget/src/android/nsAppShell.cpp
> 
> Is there a way to get notifications outside of the appshell?  This is the first
> example of having to use the app shell to get geo notifications.  If not, thats
> fine.
I think we could come up with other ways but this is the simplest way right now AFAICT.
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.