568261 - Firefox Start page momentarily flashes at incorrect scale

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

When starting Fennec, the start page flashes at large zoom before correctly re-displaying at right zoom.

This is because the viewport meta tag data is not read early enough to change the viewport before the page is initially displayed

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Simple patch adds a call to Tab.updateViewportMetadata in the DOMLinkAdded handler. The goal is to update the metadata as early as possible. Using DOMLinkAdded is just a "hack" - DOMMetaAdded will be used on trunk, but not on branch.

I put the call in the rel="icon" section of the event handler. We might want to move it out so any <link> element will trigger the call. Thoughts?

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 447556 [details] [diff] [review]
patch

Works for me, seems like a reasonable hack for the stable branch.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 447556 [details] [diff] [review]
patch

Works for me too

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-1.1:
http://hg.mozilla.org/releases/mobile-1.1/rev/057ffdc00835

will not push to m-b

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Samsung Galaxy S
OS: Android 2.2