568270 - e10s: remote nsPrefService

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[[e-mail]]

+++ This bug was initially created as a clone of Bug #506269 +++

From bug 506269 comment 31:

> Actually -- anyone in the content process that wants a prefbranch has to
> instantiate the prefservice first. We could remote nsPrefService::Init(), which
> instantiates and caches it in the parent; if that fails, we return failure to
> the child, which means nsIPrefBranch methods can't be called. Then you don't
> need an EnsurePrefService() method or the 'if (prefs)' checks here.
> 
> Speaking of which, you're not touching nsPrefService.cpp here -- specifically,
> nsPrefService::Init() fully loads up the pref file and such. All this work is
> still being done in the child, but we're just remoting the actual pref lookups.
> Fixing that can be a separate patch. Other prefservice methods, like
> nsPrefService::ReadUserPrefs(), should fail in the content process.
> 
> This will be a bunch more remoting to stuff onto ContentProcessChild/Parent;
> you probably want to add a PPrefService IPDL interface on PContentProcess. You
> don't need to do it in this patch though :)

Comment 1

[[e-mail]]

Attachment: like so

Pretty simple.

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 447583 [details] [diff] [review]
like so

a+++ would review again. r=me

Comment 3

[[e-mail]]

http://hg.mozilla.org/projects/electrolysis/rev/dc9cc3820b02