XUL code does lots of excessive calls to AddToIdTable/RemoveFromIdTable

NEW
Unassigned

Status

()

Core
XUL
8 years ago
8 years ago

People

(Reporter: sicking, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

The XUL code manually calls AddToIdTable/RemoveFromIdTable from AddSubtreeToDocument/RemoveSubtreeFromDocument. One of the results of this is that elements in bindings are added to the id-table, presumably this is intended behavior, though it seems strange to me.

However we also end up adding "normal" elements that were already added the normal way to the id-table.

We should try to remove these excessive calls so that we can add strong assertions ensuring that elements are never double-added to, or double-removed from, the id table.
> presumably this is intended behavior

It's a bug we should fix, imo.  See bug 489925 which was about this basic issue but had to be fixed in a "branch-safe" way....
You need to log in before you can comment on or make changes to this bug.