568324 - mozJSSubScriptLoader.cpp:116: warning: statement has no effect

Status: RESOLVED FIXED

Description

[Daniel Holbert [:dholbert]]

Filing this bug for this warning:
{
> js/src/xpconnect/loader/mozJSSubScriptLoader.cpp:116: warning: statement has no effect
}

The chunk of code is:
> 92 NS_IMETHODIMP /* args and return value are delt with using XPConnect and JSAPI */
> 93 mozJSSubScriptLoader::LoadSubScript (const PRUnichar * aURL
> 94                                      /* [, JSObject *target_obj] */)
> 95 {
[...]
>112 #ifdef NS_FUNCTION_TIMER
>113     NS_TIME_FUNCTION_FMT("%s (line %d) (url: %s)", MOZ_FUNCTION_NAME,
>114                          __LINE__, NS_LossyConvertUTF16toASCII(aURL).get());
>115 #else
>116     aURL; // prevent compiler warning
>117 #endif

I'm assuming we're trying to suppress an "unused" compiler warning, but in the process, we're actually causing another compiler warning.

The correct way to suppress "unused" (at least in GCC) is:
  (void)aURL;
instead of
  aURL;

Comment 1

[Daniel Holbert [:dholbert]]

Created attachment 447600 [details] [diff] [review]
fix

Comment 2

[:Ehsan Akhgari]

Comment on attachment 447600 [details] [diff] [review]
fix

Your assumption is true, this was my bad.  Thanks for catching (and fixing) this!

Comment 3

[Daniel Holbert [:dholbert]]

Landed.  Thanks for the quick review!
http://hg.mozilla.org/mozilla-central/rev/85a03643b723