568379 - Remove hasStringArgs weirdness from XPCNativeWrapper constructor

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Boris Zbarsky [:bzbarsky]]

I guess this is ok because we no longer support xpcnativewrappers=no?

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Part 1, remove hasStringArgs - v2

Comment 4

[Jason Orendorff [:jorendorff]]

Attachment: Part 2, remove DEEP flag - v2

Comment 5

[Jason Orendorff [:jorendorff]]

(In reply to comment #2)
> I guess this is ok because we no longer support xpcnativewrappers=no?

If part 1 is ok, then part 2 is ok, with high confidence.

I don't have a detailed theory of why part 1 is ok, but I think Blake thinks it is probably ok.

Comment 6

[Jason Orendorff [:jorendorff]]

Attachment: Part 2, remove DEEP flag - v2 improved edition

Fix a silly mistake that didn't show up until libxul link time.  :-P

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to comment #2)
> I guess this is ok because we no longer support xpcnativewrappers=no?

Well, that patch is still coming, but yeah, we've given extensions enough time.

Comment 8

[Jason Orendorff [:jorendorff]]

Part 1: http://hg.mozilla.org/tracemonkey/rev/6df96358fab3
Part 2: http://hg.mozilla.org/tracemonkey/rev/f8282c49548e

Comment 9

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/6df96358fab3