Fontsize handling in nsSystemFontsQt.cpp breaks for fonts with pixel size set

RESOLVED FIXED

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: Steffen Imhof, Assigned: Steffen Imhof)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 447723 [details] [diff] [review]
Patch that checks for both pixel and point size

The code in nsSystemFontsQt.cpp assumes that the Qt default font has a point size which gets turned into pixels.

But if the default font only has a pixel size, the point size returns -1 and the whole rendering of unstyled elements if totally off.
(Assignee)

Updated

8 years ago
Attachment #447723 - Flags: review?(dougt)
(Assignee)

Updated

8 years ago
Assignee: nobody → steffen.imhof
(Assignee)

Comment 1

8 years ago
Created attachment 447729 [details] [diff] [review]
Fixes the unmatched braces in previous patch

Sorry, the first patch was missing a closing brace.
Attachment #447723 - Attachment is obsolete: true
Attachment #447729 - Flags: review?(dougt)
Attachment #447723 - Flags: review?(dougt)

Updated

8 years ago
Attachment #447729 - Flags: review?(dougt) → review+

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/19a458b7ab57
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.