NativeCompareAndSwap compilation failure on mingw.

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Jacek Caban, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 447740 [details] [diff] [review]
fix

The check:

#if defined(_WIN32) && defined(_M_IX86)

passes on mingw, because the check is for OS instead of compiler, and uses MSC-specific assembly that causes compilation failure. The right version for mingw is:

#elif defined(__i386) && (defined(__GNUC__) || defined(__SUNPRO_CC))

The attached patch fixes the problem.
(Reporter)

Updated

8 years ago
Attachment #447740 - Attachment is patch: true
Attachment #447740 - Flags: review?(brendan)

Comment 1

8 years ago
Comment on attachment 447740 [details] [diff] [review]
fix

Bouncing it to our resident windows guru.
Attachment #447740 - Flags: review?(brendan) → review?(dvander)
Attachment #447740 - Flags: review?(dvander) → review+
Keywords: checkin-needed

Comment 2

8 years ago
Jacek, do you have commit access?
(Reporter)

Comment 3

8 years ago
No, I don't have. Please commit the patch.
http://hg.mozilla.org/tracemonkey/rev/51a5c26e7a63
Keywords: checkin-needed
Whiteboard: fixed-in-tracemonkey

Comment 5

8 years ago
http://hg.mozilla.org/mozilla-central/rev/51a5c26e7a63
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.