568500 - Bugzilla does not send correct Content-Type for JSON template

Status: RESOLVED FIXED

Description

[Gervase Markham [:gerv] (not reading bugmail)]

Bugzilla can be extended in a supported fashion by dropping in new templates.
http://www.bugzilla.org/docs/tip/en/html/cust-templates.html

The template to be used for a given request is chosen using the "ctype" parameter. However, Bugzilla currently only knows the correct Content Type for a few ctypes. The list is in Bugzilla/Constants.pm, the constant "contenttypes". 

It knows: html, rdf, atom, xml, js, csv, png and ics.

If an admin adds a new template which is not one of those types, Bugzilla will not send a Content-Type at all. :-(( This means that, among other things, client software may default to guessing the type as text/html and also the charset as ISO-8859-1, both of which are incorrect, and the latter of which could lead to data corruption.

For these reasons Bugzilla should know about a good set of common content types admins may use. In particular, JSON.

Gerv

Comment 1

[Gervase Markham [:gerv] (not reading bugmail)]

Created attachment 447769 [details] [diff] [review]
Patch v.1

Trivial patch.

Gerv

Comment 2

[Max Kanat-Alexander]

Comment on attachment 447769 [details] [diff] [review]
Patch v.1

Reasonable.

Comment 3

[Gervase Markham [:gerv] (not reading bugmail)]

http://bzr.mozilla.org/bugzilla/3.6/revision/7103
http://bzr.mozilla.org/bugzilla/trunk/revision/7200

(I've fixed the bug in my scripts which seems to have recorded the author as ''.)

Gerv