56859 - Unix install scripts aren't storing the build ID

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[David Epstein]

Linux build 2000101608-MN6.
1. Open up one of the installed scripts generated by build automation (e.g. 
install.js in xpcom.xpi).
2. Check addDirectory and addFile commands.
3. Look at the version string passed to them, particularly the build component 
(major.minor.release.build).
Result: 5.0.0.0000000000. no build ID in 3rd component.
Expected: 5.0.0.2000101608.
Question: Both Linux and Mac use version 5 instead of 6. Don't we want to use 6 
for the major component?

Comment 1

[Jon Granrose]

punt to samir.  I have no idea how the install.js scripts are being generated
other than a vague thought that it's in deliver.pl.

Comment 2

[Samir Gehani]

Pong.  Back to granrose.  You supply the build id to deliver.pl.
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/unix/deliver.pl#26

Comment 3

[Jon Granrose]

doh!

looking at the automation, it's looking at mozilla/build/build_number which
apparently is no longer being used (and should probably be removed from the
tree).  pointed automation to use mozilla/config/build_number which does have
the correct build id in it.

one line change to the automation to look at the correct file.  I'll attach the
diff.

cls - can you review?
leaf - can you approve?

Comment 4

[Jon Granrose]

Attachment: get buildid from config/build_number, not build/build_number

Comment 5

[Jon Granrose]

oh, and this patch is just to include the buildid.  I'm not touching the 5.0 vs
6.0 thing with a 10' pole.  That's for marketing and the installer team (and
whoever else wants to jump into the fray) to work out.

Comment 6

[cls]

r=cls on the patch.  build/build_number is going away as soon as we can land bug
26798.

Comment 7

[Daniel (Leaf) Nunes]

not sure i'm officially on the `a' list yet, but a=leaf

Comment 8

[Jon Granrose]

PDT: how bout that rtm++?

Comment 9

[David Epstein]

added pp to keyword (platform specific)

Comment 10

[David Epstein]

Build ID is also 0000000000 for the registry version in initInstall().

Comment 11

[Peter Trudelle]

PDT says rtm++, please land on branch ASAP.

Comment 12

[Jon Granrose]

fix checked in.

Comment 13

[Jon Granrose]

build id should start showing up correctly tomorrow.

Comment 14

[David Epstein]

verified on Linux branch build 2000-10-19-09-MN6. On to the trunk build.

Comment 15

[David Epstein]

Verified on Linux trunk build 2000-10-19-08-MTrunk.