Closed Bug 568600 Opened 16 years ago Closed 16 years ago

Add .private_extern directives to NSPR assembly code functions for Mac OS X.

Categories

(NSPR :: NSPR, defect)

All
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Attached patch Proposed patchSplinter Review
The attached patch adds the .private_extern directives to NSPR assembly code functions for Mac OS X so that the symbols do not become global. These functions are all internal to the NSPR library.
Attachment #447797 - Flags: superreview?(joshmoz)
Attachment #447797 - Flags: review?(mark)
Attachment #447797 - Flags: review?(mark) → review+
Attachment #447797 - Flags: superreview?(joshmoz) → review+
I checked in the patch on the NSPR trunk (NSPR 4.8.5). Checking in os_Darwin_ppc.s; /cvsroot/mozilla/nsprpub/pr/src/md/unix/os_Darwin_ppc.s,v <-- os_Darwin_ppc.s new revision: 3.3; previous revision: 3.2 done Checking in os_Darwin_x86.s; /cvsroot/mozilla/nsprpub/pr/src/md/unix/os_Darwin_x86.s,v <-- os_Darwin_x86.s new revision: 1.3; previous revision: 1.2 done Checking in os_Darwin_x86_64.s; /cvsroot/mozilla/nsprpub/pr/src/md/unix/os_Darwin_x86_64.s,v <-- os_Darwin_x86_64.s new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: