Closed Bug 568635 Opened 14 years ago Closed 14 years ago

get/set/has/delAtomProperty require Atoms to be of type String.

Categories

(Tamarin Graveyard :: Virtual Machine, defect, P4)

defect

Tracking

(Not tracked)

VERIFIED WONTFIX
Q3 11 - Serrano

People

(Reporter: stejohns, Assigned: stejohns)

Details

(Whiteboard: has-patch)

Attachments

(1 file)

There's no good reason (IMHO) they shouldn't also accept kIntptrType atoms, since they aggressively use those as keys where possible.
Attached patch PatchSplinter Review
Obvious fix, also consolidates duplicate code.

(Also, drive-by change to getAtomPropertyFromProtoChain, which was unnecessarily virtual)
Attachment #447832 - Flags: review?(edwsmith)
any test results?
Nope -- I should probably withdraw this as it's non-urgent, but it's one of those weird things I wanted to note down somewhere...
Comment on attachment 447832 [details] [diff] [review]
Patch

Nothing obviously wrong with the patch, but cancelling review until testing is further along.
Attachment #447832 - Flags: review?(edwsmith)
Whiteboard: has-patch
Assignee: nobody → stejohns
Flags: flashplayer-qrb+
Priority: -- → P4
Target Milestone: --- → flash10.2
Withdrawing.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
bulk verifying resolved !fixed issues
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: