get/set/has/delAtomProperty require Atoms to be of type String.

VERIFIED WONTFIX

Status

Tamarin
Virtual Machine
P4
trivial
VERIFIED WONTFIX
8 years ago
7 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

unspecified
Q3 11 - Serrano
Bug Flags:
flashplayer-qrb +

Details

(Whiteboard: has-patch)

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
There's no good reason (IMHO) they shouldn't also accept kIntptrType atoms, since they aggressively use those as keys where possible.
(Assignee)

Comment 1

8 years ago
Created attachment 447832 [details] [diff] [review]
Patch

Obvious fix, also consolidates duplicate code.

(Also, drive-by change to getAtomPropertyFromProtoChain, which was unnecessarily virtual)
Attachment #447832 - Flags: review?(edwsmith)

Comment 2

8 years ago
any test results?
(Assignee)

Comment 3

8 years ago
Nope -- I should probably withdraw this as it's non-urgent, but it's one of those weird things I wanted to note down somewhere...

Comment 4

8 years ago
Comment on attachment 447832 [details] [diff] [review]
Patch

Nothing obviously wrong with the patch, but cancelling review until testing is further along.
Attachment #447832 - Flags: review?(edwsmith)

Updated

8 years ago
Whiteboard: has-patch

Updated

8 years ago
Assignee: nobody → stejohns
Flags: flashplayer-qrb+
Priority: -- → P4
Target Milestone: --- → flash10.2
(Assignee)

Comment 5

8 years ago
Withdrawing.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX

Comment 6

7 years ago
bulk verifying resolved !fixed issues
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.