Closed
Bug 568677
Opened 14 years ago
Closed 14 years ago
Failure to get CryptoMeta assumes it's missing
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
1.4
People
(Reporter: Mardak, Assigned: Mardak)
References
Details
Attachments
(1 file)
4.39 KB,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
There's been some network instability recently and this is causing some requests to fail with TIMEOUT or REFUSED. This can cause badness for certain records like importing a CryptoMeta and it failing to import results in logic to create a new CryptoMeta as well as clear out existing data.
Comment 1•14 years ago
|
||
We should only do this on an explicit 404. If we get anything else, we should just fail to sync.
Target Milestone: --- → 1.4
Assignee | ||
Updated•14 years ago
|
Flags: blocking-fx-sync1.4+
Updated•14 years ago
|
Assignee: nobody → edilee
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #451123 -
Flags: review?(mconnor)
Comment 4•14 years ago
|
||
Comment on attachment 451123 [details] [diff] [review] v1 We should also have a parallel test for 404, where we'll actually regen crypto, but that doesn't need to block landing as long as a bug is on file.
Attachment #451123 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/services/fx-sync/rev/5bc06b6ced60 Explicitly check the status code to make sure we stop syncing on non-404 crypto meta failures. Add tests to check correct behavior of 404 and non-404 errors during syncStartup.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•