There's been some network instability recently and this is causing some requests to fail with TIMEOUT or REFUSED. This can cause badness for certain records like importing a CryptoMeta and it failing to import results in logic to create a new CryptoMeta as well as clear out existing data.
We should only do this on an explicit 404. If we get anything else, we should just fail to sync.
Target Milestone: --- → 1.4
Comment on attachment 451123 [details] [diff] [review] v1 We should also have a parallel test for 404, where we'll actually regen crypto, but that doesn't need to block landing as long as a bug is on file.
Attachment #451123 - Flags: review?(mconnor) → review+
http://hg.mozilla.org/services/fx-sync/rev/5bc06b6ced60 Explicitly check the status code to make sure we stop syncing on non-404 crypto meta failures. Add tests to check correct behavior of 404 and non-404 errors during syncStartup.
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.