Closed
Bug 568719
Opened 14 years ago
Closed 14 years ago
[D2D] New surfaces need to be cleared before use
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bas.schouten, Assigned: bas.schouten)
References
Details
Attachments
(1 file, 1 obsolete file)
2.45 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
There's several bugs particularly with SVG filters that point this problem out when using NVidia drivers and Direct2D without the debug layer. The drivers can choose to reuse existing video memory, which already contains data. We need to make sure our surfaces are empty before using them.
Attachment #447888 -
Flags: review?(jmuizelaar)
Comment 1•14 years ago
|
||
Comment on attachment 447888 [details] [diff] [review] Clear surfaces when created Seems like this should move into a helper function and add a comment about why it needs to be done. It also looks like this patch adds a Flush(). What's that for?
Attachment #447888 -
Flags: review?(jmuizelaar) → review-
Assignee | ||
Comment 2•14 years ago
|
||
(In reply to comment #1) > (From update of attachment 447888 [details] [diff] [review]) > Seems like this should move into a helper function and add a comment about why > it needs to be done. It also looks like this patch adds a Flush(). What's that > for? I can move it into a helper function. The flush needs to go away, it serves no purpose and ended up in there by accident.
Assignee | ||
Comment 3•14 years ago
|
||
Fixed review comments.
Attachment #447888 -
Attachment is obsolete: true
Attachment #448074 -
Flags: review?(jmuizelaar)
Comment 4•14 years ago
|
||
Comment on attachment 448074 [details] [diff] [review] Clear surfaces when created v2 The comment should include why we need to clear surface. It does not need to include "This clears a D2D surface", that is obvious from the function name.
Attachment #448074 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/d8a36dd3fc3c.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•