568727 - Update packaging for automation scripts

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we are using a really messy method to load necessary modules from a sub folder which is not in the system path. As Jeff mentioned I will have to look at http://k0s.org/portfolio/packaging.html

Comment 1

[Jeff Hammel]

For e.g. http://github.com/whimboo/mozmill/blob/firefox-automation/scripts/firefox-automation/testrun_bft.py this should be easy.  Instead of doing

{{{
base_path = os.path.dirname(os.path.abspath(__file__))
sys.path.append(os.path.join(base_path, 'libs'))

from testrun import BftTestRun
}}}

Add a __init__.py file to the 'libs' subdirectory (it can be an empty file, as long as it's there), then just make it `from libs.testrun import BftTestRun`.

I'm not sure why things are organized the way they are (e.g., libs seems counter-intuitive to me), but I haven't had a chance to really study this code, but that's another issue

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #1)
> Add a __init__.py file to the 'libs' subdirectory (it can be an empty file, as
> long as it's there), then just make it `from libs.testrun import BftTestRun`.

Lets see if that works.

> I'm not sure why things are organized the way they are (e.g., libs seems
> counter-intuitive to me), but I haven't had a chance to really study this code,
> but that's another issue

Shall I call it testrun? The reason is that I do not want to clutter the root where all the scripts are located you can execute.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Simply fix to correctly use the packaging method of Python.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/c5c83155c14b