56881 - domviewer only displaying unknown:unknown

Status: VERIFIED WONTFIX

(SeaMonkey :: General, defect, P5)

Description

[Axel Hecht]

There are quite a few bugs on domviewer, but most have a ancient history, and
started off as something different. So I create a new specific one.

After jag change the xul to get rid of a rdf: namespace, the domviewer came
back to something close to life.
But it only shows "unknown" for name and value. As far as gdb made me go, this
is due to the QI to nsIDOMViewerElement in
http://lxr.mozilla.org/seamonkey/source/rdf/tests/domds/nsRDFDOMDataSource.cpp#735
failing. Then the resources loose their dom nodes, and the thing goes down.

At least that's what I think. Tested on CVS from Oct. 16.

Axel

Comment 1

[Alec Flett]

hewitt is reviving domviewer for his property inspector. 

Have jag's changes been checked in?

Comment 2

[Axel Hecht]

jag's stuff is checked in,
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/rdf/tests/domds/resources&command=DIFF_FRAMESET&file=DOMDataSourceViewer.xul&rev1=1.18&rev2=1.19&root=/cvsroot


Axel

Comment 3

[Joe Hewitt (gone)]

The reason it displays unknown unknown is that the wrong resource factory id is 
being used at:

http://lxr.mozilla.org/seamonkey/source/rdf/tests/domds/nsRDFDOMDataSource.cpp#7
25

simply change "object://" to "dom://" and voila it works.

Comment 4

[Joe Hewitt (gone)]

I'm attaching a file with two patches that fix the DOM Viewer 100% (in addition 
to jag's changes).  The other change is just adding a class="treecell-indent" 
to the xul.

Comment 5

[Joe Hewitt (gone)]

Attachment: revival patch

Comment 6

[Axel Hecht]

So this was rather easy. Just noting the following:
I don't know what to expect, but it looks like the Name's are all empty(?).

If I selected dom, and then select frames, I get a segfault. Too late to start
debuggin tonight, I might come up with something more useful later. Anybody
to verify this?

Anyway, this is a good step forward.

Axel

Comment 7

[Alec Flett]

cool! r/a=alecf

Comment 8

[Alec Flett]

name shouldn't be blank, that should be the the "nodeName" attribute of the 
node.

Comment 9

[Axel Hecht]

r=[e-mail], I don't see the problems with the missing display values
anymore.
May have been my fault, or something changed elsewhere fixing this.

Axel

Comment 10

[Joe Hewitt (gone)]

I'm not planning on working on the old DOM viewer anymore.  A long time ago I
started a new project called document inspector which extends DOM Viewer in many
new directions.  I'm still trying to get this checked into the tree.  Marking
WONTFIX

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

verified.  Joe has checked his document inspector into the tree (I believe you 
have to build with special flags, but it's there.)

Comment 12

[Hixie (not reading bugmail)]

Obsolete DOM Viewer bugs -> Browser-General; DOM Viewer component is going away.