Mozrunner breaks binary component during installation

VERIFIED FIXED

Status

Testing
Mozbase
--
critical
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Trunk
All
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MozMillAddonTestday][mozmill-1.4.2])

(Assignee)

Description

8 years ago
When we extract an XPI for a binary extension Mozrunner writes the files as ASCII and not binary. The problem we have with it on Windows is that all extensions with binary components are broken, because even DLL files will be written as ASCII files.

Patch upcoming. We should fix it ASAP
(Assignee)

Comment 1

8 years ago
Patch is up on:
http://github.com/whimboo/mozrunner/commit/3e95ae5bad5dca64e940a7b4fcf4b377036ecb15
Status: NEW → ASSIGNED
(Assignee)

Comment 2

8 years ago
Patch has been merged with Mikeal's master, version has been bumped up, tag set, and uploaded to PyPI. We are good to go now.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

8 years ago
Verified fixed with 2.4.3 and Google Toolbar extension.
Status: RESOLVED → VERIFIED
Whiteboard: [mozmill-1.4.2]
(Assignee)

Updated

8 years ago
Whiteboard: [mozmill-1.4.2] → [MozMillAddonTestday][mozmill-1.4.2]
(Assignee)

Updated

8 years ago
Assignee: nobody → hskupin
You need to log in before you can comment on or make changes to this bug.