568882 - TabCandy should not reorder tabs

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

i keep finding my tabs in different order. i'm not sure what causes it - switching between groups, or restarting, or both, or something else?

but it's really problematic. nothing should change tab order outside of explicit user actions to do so.

Comment 1

[Ian Gilman [:iangilman]]

We're actually not yet making any explicit effort to maintain the order when you restart the browser... that's probably what's going on here, and it certainly needs to be fixed.

Comment 2

[Brian Polidoro]

Restarting isn't needed to see the problem.

STR.
1. Open some tabs.  
2. Put them in a group. The order of them is Order A.
3. Reorder your tabs with the tab bar. Order B
4. Open a new tab in some way using the browser chrome:  Middle click on a bookmark, use the new tab button, etc.  New tabs from content like from middle clicking on a link doesn't show the problem.

After step 4 your tabs will be be back in order A with the new tab at the right end of the tab bar.  

Reordering while looking at the tab groups with tab candy seems to be the only way to make permanent tab order changes.

Comment 3

[Dietrich Ayala (:dietrich)]

bumping priority. the loss of order causes enough mental strife to prevent daily dogfooding.

Comment 4

[Ian Gilman [:iangilman]]

I think ideally we'd catch "tab order changed" events from the browser and save the new order then. Does anyone know if there is such a thing?

Comment 5

[Dietrich Ayala (:dietrich)]

https://developer.mozilla.org/en/Code_snippets/Tabbed_browser#Notification_when_a_tab_is_added_or_removed

Comment 6

[Ian Gilman [:iangilman]]

Thanks! 

Fixed in:

http://hg.mozilla.org/labs/tabcandy/rev/166c3c99d1fd

Comment 7

[(no longer active)]

Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".