568885 - Put Cu.Sandbox globals in a separate compartment from non-sandbox objects in the same domain

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

One result is that Greasemonkey scripts will be in a separate compartment from the Web pages they modify.

GM scripts already get XPCNWs of content objects. Putting GM in a separate compartment will mean separating them from content with a full membrane: content will get SJOWs of GM objects.

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: v1

Simple.

CompartmentChecker is not too happy about this because the existing wrappers don't update cx->compartment when moving across compartment boundaries. So once we land this, we can't do per-compartment heaps until after we enable the new wrapper implementations and make the compartment assertions happy again (in Nashville we decided not to do that in parallel after all, so it's ok).

Also: it will be hard for the RewrapObject (the XPConnect implementation of the new JSWrapObjectCallback we've added to the JSAPI) to avoid tripping those assertions. We may need to disable the assertions when that hook is being called. Dangerous. :-\

Comment 3

[Andreas Gal :gal]

Reviewing now. Sorry for being slow.

Comment 4

[Andreas Gal :gal]

Comment on attachment 454306 [details] [diff] [review]
v1

Looks good. Can't wait to test with it.

Comment 5

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/tracemonkey/rev/4ae676e522f4

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/4ae676e522f4