568952 - Fennec should be able to become a default browser on Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Alex Pakhotin (:alexp)]

We have to handle the corresponding intents.

Comment 1

[Alex Pakhotin (:alexp)]

Attachment: Fix

Added <intent-filter> entries to AndroidManifest.xml

Comment 2

[Alex Pakhotin (:alexp)]

Depends on the bug 568927 as the Back button must be handled properly to return from Fennec to the app, which opened a browser.

Comment 3

[Alex Pakhotin (:alexp)]

Pushed:
http://hg.mozilla.org/users/vladimir_mozilla.com/mozilla-droid/rev/7cae40ea453c

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Er -- what's the point of pushing just the manifest change?  That means that the system will indeed offer to launch Fennec, but once it's launched, it won't actually open the link that the user clicked on because there's nothing that actually handles those intents in our app code...

We need to handle android.intent.action.VIEW and android.intent.action.WEB_SEARCH for this to actually work, no?

Comment 5

[Michael Wu [:mwu]]

From what I understand we already handle the URL correctly and this was the only change required to make things work.

Comment 6

[Alex Pakhotin (:alexp)]

(In reply to comment #4)
> We need to handle android.intent.action.VIEW and
> android.intent.action.WEB_SEARCH for this to actually work, no?

Everything already works with just the manifest change - both clicking on the
links and search. We do pass the argument to Gecko and the URL gets opened
properly.

Comment 7

[Michael Wu [:mwu]]

I just tested and verified this patch on an N1. Works as expected.

Comment 8

[Aakash Desai [:aakashd]]

Yep, verified on build:

Mozilla/5.0 (Android; U; Linux armv71; en-US; rv:1.9.3a4pre) Gecko/20100601 Namoroka/3.7a4pre Fennec/2.0a1pre

Comment 9

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/c959bd3d4b74

Comment 10

[Aakash Desai [:aakashd]]

litmus testcase https://litmus.mozilla.org/show_test.cgi?id=12635 created to regression test this bug.