568961 - Need a function to clear a textbox

Status: RESOLVED WONTFIX

Description

[Marc-Aurèle DARCHE]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: 

A new method in the Mozmill Controller Object to blank a textbox, without having to use the controller keypress method with 'VK_BACK_SPACE' for each letter, would be much welcome.

The keypress method is effective only on the input of the textfield element, which is impossible to get through the element id, one has to resort to use a mochi path. That's why this new blanking method should be given the textfield element, just like the type method.

Reproducible: Always

Comment 1

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

This function could do the following:

keypress: select all
keypress: delete

Comment 2

[Andrew Halberstadt [:ahal]]

I'm not sure if this is worthy of a new controller method.  Maybe we can pass in an optional flag to the type method which tells it to either append to the text box or overwrite it.

So you could do:
controller.type(textbox, '', true)

to clear it.

Comment 3

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

I would more tend to say a wontfix. If you want to work on an empty textbox, clear it first. I don't see a reason to bundle that into type(). With our refactoring of the shared modules it will also be much clearer.

Comment 4

[cmtalbert]

wontfix per comment 3, which I agree with.

Comment 5

[Marc-Aurèle DARCHE]

We can't expect developers to come up with the following code which is not straightforward at all:

  var utils = require('../../../../lib/utils');
  var select_all_key = utils.getEntity(['chrome://browser/locale/browser.dtd'],
      'selectAllCmd.key');
  controller.keypress(elem, select_all_key, { accelKey: true });
  controller.keypress(elem, 'VK_DELETE', {});

The fact that this code is used in tests/addons/[e-mail]/lib/selenium.js through the "clearBaseURLField" method as well as in the fidesfit-client extension advocates for its factoring out.

So reopening.

Could we add this method in mozmill-tests/lib/utils.js please?

Comment 6

[Marc-Aurèle DARCHE]

(In reply to comment #5)
> 
> Could we add this method in mozmill-tests/lib/utils.js please?

I will gladly provide a patch once I have your agreement on the interest of such a method.

Thank you

Comment 7

[Henrik Skupin (:whimboo) [⌚️UTC+1]]

Mozmill will reach its end of life soon. We are currently working on getting all the tests for Firefox ported to Marionette. For status updates please see bug 1080766.