jstests.py depends on non-'src' dir

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: vlad, Assigned: dmandelin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Trying to run jstests using the shell built as part of a browser build fails, because the shell will live in a 'objdir/js/src' directory, and manifest.py bails out if it sees a directory named 'src' at http://hg.mozilla.org/mozilla-central/diff/4b1f9afcedb1/js/src/tests/manifest.py#l34 .  A simple fix might be to just get rid of that check -- have it look for config/autoconf.mk in every directory from the current one back up to the root.  That'll work for running the tests even from the objdir/dist/bin directory (since it'll find the toplevel config/autoconf.mk, which should have all the needed bits in it).
(Assignee)

Comment 1

8 years ago
Created attachment 448144 [details] [diff] [review]
Patch
Assignee: general → dmandelin
Attachment #448144 - Flags: review?(vladimir)
Comment on attachment 448144 [details] [diff] [review]
Patch

looks good to me, thanks!
Attachment #448144 - Flags: review?(vladimir) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/tracemonkey/rev/4b0c9535865d
Whiteboard: fixed-in-tracemonkey

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/4b0c9535865d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.