568991 - jstests.py depends on non-'src' dir

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Trying to run jstests using the shell built as part of a browser build fails, because the shell will live in a 'objdir/js/src' directory, and manifest.py bails out if it sees a directory named 'src' at http://hg.mozilla.org/mozilla-central/diff/4b1f9afcedb1/js/src/tests/manifest.py#l34 .  A simple fix might be to just get rid of that check -- have it look for config/autoconf.mk in every directory from the current one back up to the root.  That'll work for running the tests even from the objdir/dist/bin directory (since it'll find the toplevel config/autoconf.mk, which should have all the needed bits in it).

Comment 1

[David Mandelin [:dmandelin]]

Attachment: Patch

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 448144 [details] [diff] [review]
Patch

looks good to me, thanks!

Comment 3

[David Mandelin [:dmandelin]]

http://hg.mozilla.org/tracemonkey/rev/4b0c9535865d

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/4b0c9535865d