569127 - Viweing bookmarks does not release GDI handles

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[nightstalkerz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100530 Minefield/3.7a5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a5pre) Gecko/20100530 Minefield/3.7a5pre

If you have a lot of bookmarks in one folder and you view them using the bookmarks menu, each favicon take up 1 GDI handle

Reproducible: Always

Steps to Reproduce:
1. Create a lot of bookmarks in 1 folder (~600+ bookmarks)
2. Use the bookmarks menu or the bookmarks manager and open the folder which contains the bookmarks or expand every folder to view the bookmarks
Actual Results:  
Each bookmark uses 1 GDI handle and is not released until Firefox closes.

Windows can become quite sluggish if there's a lot bookmarks.

Expected Results:  
The GDI handles are released when the bookmarks menu/manager closes or the try to keep the GDI handle down when viewing bookmarks like Chrome/Opera.

Might only occur with bookmarks with favicons which is probably quite common.

Comment 1

[Jo Hermans]

related to bug 472677 ?

Comment 2

[nightstalkerz]

Looks very similar but according to comment #14, it should go away after a while but this doesn't appear to go away.

Comment 3

[Tim (fmdeveloper)]

Is this still an issue with Firefox 9.0.1?

If so, can you provide a backup of a folder that causes the issue?

Comment 4

[nightstalkerz]

Attachment: places.sqlite zip

Replace the existing places.sqlite with this one

Comment 5

[nightstalkerz]

Use the bookmarks menu item or the bookmarks toolbar button and hover over each folder so the bookmarks in them gets displayed.

The bookmarks manager does not have this issue.

Comment 6

[Marco Bonardo [:mak]]

this is actually expected, when opening a menu we keep its result alive, because that improves performances of navigating through menus. Though we may evaluate if it's still the case.

Comment 7

[Bogdan Maris, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20130725 Firefox/25.0

No longer reproducible on latest Nightly (buildID: 20130725030212). If anyone does reproduce the issue please reopen this bug.