Closed
Bug 569144
Opened 16 years ago
Closed 16 years ago
tbplbot doesn't get suggestions for failures in delaytest.html?transparent-animation.gif
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: ehsan.akhgari)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1017 bytes,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Not sure where the "?" messes us up, since https://api-dev.bugzilla.mozilla.org/latest/bug?whiteboard=orange&summary=delaytest.html%3Ftransparent-animation.gif does return the bug, but instances of bug 558678 don't get a tbplbot suggestion of it. Apparently a regression, since bug 558678 comment 2 says that at one point, it did work.
|
Assignee | |
Comment 1•16 years ago
|
||
This is a regression from bug 562322.
|
|
Assignee | |
Comment 2•16 years ago
|
||
The problem is that we look for " | ", whereas the log line ends in " |\n", causing us to end up with only two tokens and bail out.
This patch uses preg_split with /\s\|\s/, which correctly handles " |\n" as well as the usual " | ".
Attachment #448288 -
Flags: review?(mstange)
|
||
Updated•16 years ago
|
Attachment #448288 -
Flags: review?(mstange) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•16 years ago
|
||
deployed
|
||
Updated•11 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•11 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•