Hash for local file installs never has a chance to be computed

VERIFIED FIXED in mozilla2.0b1

Status

()

VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Unfocused, Assigned: Unfocused)

Tracking

Trunk
mozilla2.0b1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus -

Firefox Tracking Flags

(blocking2.0 -)

Details

(Whiteboard: [AddonsRewrite])

Attachments

(1 attachment)

In the AddonInstall constructor (for the XPI provider), if the install is a local file, this.hash is checked to see whether a hash of the file should be computed. aHash is passed as a parameter, but is never set as this.hash (for local installs only). Therefore, even if a hash is passed in, it will never be checked.
blocking2.0: --- → ?
Flags: in-testsuite?
Flags: in-litmus-
Whiteboard: [rewrite] → [AddonsRewrite]
Version: unspecified → Trunk
Doesn't seem to be blocking any features in Firefox 4, would be nice to fix though.
blocking2.0: ? → -
Created attachment 448656 [details] [diff] [review]
One-line fix
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attachment #448656 - Flags: review?(dtownsend)
Comment on attachment 448656 [details] [diff] [review]
One-line fix

Can you add a test too please?
Attachment #448656 - Flags: review?(dtownsend) → review+
I'm rolling the fix and test for this into bug 570200
Depends on: 570200
Fixed by the patch in bug 570200
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3
Tinderbox looks greenish in our area. Marking as verified fixed based on automated test results.
Status: RESOLVED → VERIFIED
Target Milestone: mozilla1.9.3 → mozilla1.9.3a6
You need to log in before you can comment on or make changes to this bug.