Closed
Bug 569194
Opened 14 years ago
Closed 14 years ago
Hash for local file installs never has a chance to be computed
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla2.0b1
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | - |
People
(Reporter: Unfocused, Assigned: Unfocused)
References
Details
(Whiteboard: [AddonsRewrite])
Attachments
(1 file)
|
1.47 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
In the AddonInstall constructor (for the XPI provider), if the install is a local file, this.hash is checked to see whether a hash of the file should be computed. aHash is passed as a parameter, but is never set as this.hash (for local installs only). Therefore, even if a hash is passed in, it will never be checked.
|
||
Updated•14 years ago
|
blocking2.0: --- → ?
Flags: in-testsuite?
Flags: in-litmus-
Whiteboard: [rewrite] → [AddonsRewrite]
Version: unspecified → Trunk
|
||
Comment 1•14 years ago
|
||
Doesn't seem to be blocking any features in Firefox 4, would be nice to fix though.
blocking2.0: ? → -
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
||
Comment 3•14 years ago
|
||
Comment on attachment 448656 [details] [diff] [review] One-line fix Can you add a test too please?
Attachment #448656 -
Flags: review?(dtownsend) → review+
|
|
||
Comment 5•14 years ago
|
||
Fixed by the patch in bug 570200
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Updated•14 years ago
|
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3
|
|
||
Comment 6•14 years ago
|
||
Tinderbox looks greenish in our area. Marking as verified fixed based on automated test results.
Status: RESOLVED → VERIFIED
|
|
||
Updated•14 years ago
|
Target Milestone: mozilla1.9.3 → mozilla1.9.3a6
You need to log in
before you can comment on or make changes to this bug.
Description
•