569216 - Cocoa progress widget should support RTL

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

The HTML5 progress element is going to use -moz-appearance: progressbar (see bug 567872). On MacOS X, the progress bar draw the chunks itself so we need to manage the RTL from there.

Let me know if you prefer to have a |mirrorHorizontal| parameter instead of checking inside |DrawProgress|.

Comment 1

[Markus Stange [:mstange]]

Please use RenderTransformedHIThemeControl like DrawResizer does. That doesn't only do the horizontal mirroring for you, it also fixes rendering bugs with transformed progress bars. For example, try setting style="transform:rotate(45deg)" on a progressbar - the result will look very strange. RenderTransformedHIThemeControl gets around these bugs by painting the control into a buffer and only transforming the result.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Trying to use RenderTransformedHIThemeControl

It looks like RenderTransformedHIThemeControl does not do the drawing where it should.

Comment 3

[Markus Stange [:mstange]]

I think you need to pass aRenderRect to HIThemeDrawTrack where you're passing NULL.

Comment 4

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Comment 5

[Mounir Lamouri (:mounir)]

Thank you for your advices Markus !

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This could use a test.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/1327d8097f0c

Comment 8

[Markus Stange [:mstange]]

Mounir, you can look at http://hg.mozilla.org/mozilla-central/rev/074779c640fb for the reftests from the rtl resizer bug. They're basically just doing direction:rtl == -moz-transform:scaleX(-1).