Most or all Install::DB functions should inform the user that they are doing something

RESOLVED FIXED in Bugzilla 4.0

Status

()

--
enhancement
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

Bugzilla 4.0

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Some Install::DB functions silently upgrade data in the database, and this can hide bugs. Every function should print out a message when it is actually doing work on the database.
(Assignee)

Comment 1

8 years ago
Created attachment 448457 [details] [diff] [review]
v1

Okay, now all of Install::DB prints out a message if it conditionally does something. (Things that it *always* does may not print messages--we know that those are always happening, we don't need to be informed, I think.)

This also let me figure out what was slow in the "copying old chart data into the database" part, and I put a transaction around it, which sped it up considerably.
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Attachment #448457 - Flags: review+
(Assignee)

Comment 2

8 years ago
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Install/DB.pm
Committed revision 7203.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Keywords: relnote
(Assignee)

Comment 3

8 years ago
Added to the release notes in bug 604256.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.