569337 - Fix compilation issues when SVG and SMIL are disabled

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

When svg is disabled (which automatically disble smil), the current m-c do not compile. The attached patch fixes the issues I had.

The patch is really small (6 new lines).

(it's in the layout component because it only affects layout)

Comment 1

[Robert Longson [:longsonr]]

We could do with less MOZ_SVG rather than more. Couldn't we just always have SetSVGMode defined?

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 448506 [details] [diff] [review]
Patch v1

I tend to agree with Robert, but this seems ok for now.  However, in this change:

>diff --git a/layout/style/nsStyleAnimation.cpp b/layout/style/nsStyleAnimation.cpp
>+#ifdef MOZ_SVG
>   if (aUseSVGMode) {
>     parser.SetSVGMode(PR_TRUE);
>   }
>+#endif // MOZ_SVG

you probably want:

  if (aUseSVGMode) {
#ifdef MOZ_SVG
    parser.SetSVGMode(PR_TRUE);
#else
    NS_NOTREACHED("aUseSVGMode should not be set");
#endif
  }

r=dbaron with that

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

r=dbaron

I also agree with you Robert but I prefer to have this patch landed then having a patch changing some SVG functions to be defined but empty when !MOZ_SVG.

Comment 4

[Robert Longson [:longsonr]]

I didn't mean to imply that the methods would be defined but empty. I was suggesting that they be implemented for all builds so MOZ_SVG gradually dies.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/eca005852720